This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [v3] <regex> implementation foundation, version 3

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: stephen dot webb at bregmasoft dot ca
Cc: "Stephen M. Webb" <stephenw dot webb at bregmasoft dot ca>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Wed, 23 Jun 2010 23:56:55 +0200
Subject: Re: [v3] <regex> implementation foundation, version 3
References: <201006231622.08970.stephenw.webb@bregmasoft.ca> <201006231649.41144.stephenw.webb@bregmasoft.ca>

Hi,
>> Excellent, thanks. As far as I'm concerned, I think we are *very* close
>> to the point of actually committing the code. Maybe Jon has more comments.
>>     
> If I get no more comments in 24 hours or so should I go ahead and commit, 
> then?
>   
I think so. Make sure to include in your regression tests also a 32-bit
target, x86_64 multilib is fine. Also, it would be nice if you could
also run the testsuite with CXXFLAGS="-O2 -g -Wall", we strive to keep
the testsuite -Wall clean.
> The linker script change is included in the patch.
Oops, I didn't see it, sorry. You know what I think, let's leave out
those three defs for now, and let's add instead 3 XXX FIXME comments in
the *.h. Also I would suggest FIXME comment before the big inline
functions defined in *.tcc files, sooner or later must go.

Thanks,
Paolo.

References:
- [v3] <regex> implementation foundation, version 3
  - From: Stephen M. Webb
- Re: [v3] <regex> implementation foundation, version 3
  - From: Stephen M. Webb

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]