This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] <regex> implementation foundation, version 1
On 06/20/2010 06:28 AM, Paolo Carlini wrote:
> ... I would suggest to do that first, at least as an initial
> approximation. When you will be *really* sure that your data
> structures are stable, then you will finally identify some large out
> of line functions that you want to explictly instantiate and export,
> maybe involving vector too. I would not attempt to do that now, it's
> way too early. And in any case if it's all about templates, doesn't
> seem to me at all urgent for code size, only maybe for compile time
> performance, because weak linkage helps you anyway for large
> functions. Just as an example, vectors are used also in <random> and
> we don't have any urgent plan to export anything.
Had a look to the code, and besides an handful of _StateSeq and free
functions, I'm seeing only very small functions in *.cc files, which
should be inline anyway, thus in header. Just move everything to headers
only, all in inline for now and be done with it.
While we are at it, remember to wrap *everything* to 80 columns and
unless you are really, really sure you are not taking the address
anywhere in the code, I would add the missing out of class definitions
for the _S_token_* and _S_state_* constants.
Paolo.