This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] Avoid -Wall warnings in the testsuite
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 08 Jun 2010 10:00:13 +0200
- Subject: Re: [v3] Avoid -Wall warnings in the testsuite
- References: <4C0D930E.60101@oracle.com> <20100608061031.GU10293@tyan-ft48-01.lab.bos.redhat.com>
Hi,
> On Tue, Jun 08, 2010 at 02:47:10AM +0200, Paolo Carlini wrote:
>
>> tested x86_64-linux, CXXFLAGS="-O2 -g -Wall", committed.
>>
> Anything that looked like a compiler bug (i.e. decl on which it warned, yet
> it was used somewhere else than on lhs of an assignment)?
>
No, yesterday I didn't notice anything, thanks. Actually I was a bit
tired when I completed the work, I may have missed something and today,
among other things, I was considering skimming again through the patch.
I'll let you know immediately, in case.
> The two PRs I've fixed yesterday were from quick skimming of the libstdc++
> testsuite results with
> RUNTESTFLAGS=--target_board=unix/-Wunused-but-set-variable/-Wunused-but-set-parameter
> but of course I could have missed something...
>
I see. Indeed, I saw your patches and at least the issue with
__attribute__((unused)) looked familiar ;) Thus I waited for Jason to
approve both before my clean-up.
Paolo.