This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][libstdc++-v3 parallel mode] Correct part lengths calculation for parallel partial_sum
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Johannes Singler <singler at kit dot edu>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 8 Jun 2010 08:39:12 +0100
- Subject: Re: [PATCH][libstdc++-v3 parallel mode] Correct part lengths calculation for parallel partial_sum
- References: <4C0DEF94.5020404@kit.edu>
On 8 June 2010 08:21, Johannes Singler wrote:
> This patch corrects the calculation of the part lengths for parallel
> partial_sum, leading to the expected behavior for
> partial_sum_dilation!=1, and thus better performance.
>
> Tested x86_64-unknown-linux-gnu: No regressions.
>
> Please approve for mainline.
>
> 2010-06-08 ?Johannes Singler ?<singler@kit.edu>
>
> ? ? ? ?* include/parallel/partial_sum.h
> ? ? ? ?(__parallel_partial_sum_linear):
> ? ? ? ?Correctly calculate part lengths for partial_sum_dilation!=1.
Please declare each variable on its own line, as per
http://gcc.gnu.org/onlinedocs/libstdc++/manual/source_code_style.html
char* c = "abc"; // each variable goes on its own line, always.
(Unfortunately the coding style guide seems to have got mangled by the
conversion to docbook, I'll fix that.)