This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: make unique_ptr<T,D> use D::pointer if it exists

From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
To: "libstdc++" <libstdc++ at gcc dot gnu dot org>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Sat, 24 Apr 2010 10:21:26 +0100
Subject: Re: make unique_ptr<T,D> use D::pointer if it exists
References: <v2r4348dea51004230900l26b6c38ex22495a97d96eb3eb@mail.gmail.com>

On 23 April 2010 17:00, Jonathan Wakely wrote:
> We don't conform to [unique.ptr.single] paragraph 3, i.e. we don't use
> the deleter's pointer type.
>
> I won't be able to add new tests and commit it for a couple of days

I got some time while on a train, so I improved the patch by moving
the helper inside unique_ptr and added a test.

        * include/bits/unique_ptr (unique_ptr::pointer): Use deleter's
        pointer type if it exists.
        * testsuite/20_util/unique_ptr/requirements/pointer_type.cc: New.
        * testsuite/20_util/unique_ptr/assign/assign_neg.cc: Adjust.
        * testsuite/20_util/unique_ptr/modifiers/reset_neg.cc: Adjust.

Tested x86_64/linux, committed to trunk

Attachment: up.txt
Description: Text document

References:
- make unique_ptr<T,D> use D::pointer if it exists
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]