This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix for DR 925


Hi,
> Well, let's pretend I didn't send you that lazy patch. A properly
> written, with test case, is attached. Let me know if there's still
> something missing.
*Very* minor nits. For example details about the ChangeLog entry, the
testcase is missing the test variable (which goes together with VERIFY),
copyright year should be only 2010, and similar nits. I'll take care of
that an post the final patch, please have a look to it. For now, thanks
a lot!
> Changelog:
>
> * include/bits/shared_ptr.h (shared_ptr(unique_ptr &&),
> shared_ptr(auto_ptr &&)): Remove explicit specifier
> (as per DR 925).
> * include/bits/shared_ptr_base.h: likewise
>
> PS: the abi_check test didn't pass (it didn't even before the patch), is
> this bad?
Well, it depends: if you are also seeing some ~300 unsupported tests,
likely it's because you don't have installed a full set of localedata, see:

http://gcc.gnu.org/onlinedocs/libstdc++/manual/setup.html#manual.intro.setup.prereq

thus, nothing particularly interesting. I suppose you are on x86 /
x86_64-linux, right?

Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]