This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: PATCH: Reguire __cxa_atexit for ext/{new, throw}_allocator/deallocate_global.cc
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Rainer Orth <ro at CeBiTec dot Uni-Bielefeld dot DE>
- Cc: Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Paolo Carlini <paolo dot carlini at oracle dot com>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Mon, 1 Mar 2010 12:44:28 -0800
- Subject: Re: PATCH: Reguire __cxa_atexit for ext/{new, throw}_allocator/deallocate_global.cc
- References: <yddtyt6ln07.fsf@CeBiTec.Uni-Bielefeld.DE> <4B853C02.5000204@oracle.com> <4B854F49.5050104@gmail.com> <ydd7hpv4wko.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
> > Shouldn't this be xfailed on solaris, rather than skipped on all
> > non-cxa_atexit targets?
>
> no, this way lies madness ;-( I'm strongly opposed to added any
> target-based xfails or skips if there's a general feature that can be
> tested for.
Thank you. Agreed 100%.
> A
> prominent example (which I'll attack soon) is the large list of
> different target lists used to decide if the target has pthread
> support. This is both inconsistent and a nightmare to maintain, e.g.
> if adding a new target.
Hallelujah. Thank you for tackling this, it is most apprecaited. This is
already a nightmare to maintain and was never intended to last as long
as it has.
(And as an aside, I think for solaris -pthread (no s) no works so can
be massively simplified anyway.)
-benjamin