This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Reuse integral_constant and enable_if in <functional>
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Daniel Frey <d dot frey at gmx dot de>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Mon, 25 Jan 2010 23:27:58 +0100
- Subject: Re: Reuse integral_constant and enable_if in <functional>
- References: <9EBE4B6C-81AD-47AA-A8C0-4251EAFBDAC0@gmx.de>
Hi,
> While reading through <functional>, I wondered why is_bind_expression and is_placeholder do not use integral_constant. Also, I wondered why __gnu_cxx::__enable_if was used instead of enable_if. The attached patch reflects these changes. In case the latter (enable_if) is accepted, it may also be possible to remove the include for ext/type_traits.h, right? Or is there any other reason why it's there?
>
I don't think there is. I would suggest removing it, and testing
(preferably without PCHs, because you are tweaking the includes, you can
either configure without or just delete by hand the generated pch files
and invoke make check from inside the libstdc++-v3/testsuite subdir of
the build directory). Likely some dg-error line numbers must be
adjusted. Also, please also provide a ChangeLog entry together with any
patch you are submitting.
Thanks!
Paolo.