This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: manual patch
Here is a new proposition with all you remarks considered. I don't
really understand why files that are generated from others are part of
the SVN repository but I moved my modif on the xml files.
I removed the modification on the answer to the iterator overhead. I
guessed that the 'Very little' overhead when using this technique is
limited to the compilation time, that is to say that it slow down the
sources compilation. If I guessed wrong then it could be great to
complete the answer or to simply change it to say 'None'.
Thanks
Jonathan Wakely wrote:
===================================================================
--- libstdc++-v3/doc/html/manual/locales.html (révision 156047)
+++ libstdc++-v3/doc/html/manual/locales.html (copie de travail)
@@ -18,7 +18,7 @@
</p></blockquote></div><p>
Facets actually implement locale functionality. For instance, a facet
called numpunct is the data objects that can be used to query for the
-thousands separator is in the German locale.
+thousands separator in the German locale.
It might be better to say "in a locale" instead, originally it
referred to a specific locale (the German one) but your change makes
it nonspecific.
Also "is the data objects" is bad grammar - that should be fixed too.
Index: doc/xml/manual/allocator.xml
===================================================================
--- doc/xml/manual/allocator.xml (révision 156082)
+++ doc/xml/manual/allocator.xml (copie de travail)
@@ -81,7 +81,7 @@
</itemizedlist>
<para>
- Complete details cam be found in the C++ standard, look in
+ Complete details can be found in the C++ standard, look in
<constant>[20.4 Memory]</constant>.
</para>
@@ -146,7 +146,7 @@
<para>
The only allocator interface that
- is support is the standard C++ interface. As such, all STL
+ is supported is the standard C++ interface. As such, all STL
containers have been adjusted, and all external allocators have
been modified to support this change.
</para>
@@ -202,7 +202,7 @@
</para>
<para>
This test shows the ability of the allocator to reclaim memory
- on a pre-thread basis, as well as measuring thread contention
+ on a per-thread basis, as well as measuring thread contention
for memory resources.
Test source
<ulink url="http://gcc.gnu.org/viewcvs/trunk/libstdc%2B%2B-v3/testsuite/performance/23_containers/insert_erase/associative.cc?view=markup";>here</ulink>.
@@ -447,8 +447,8 @@
<para>The <varname>thr</varname> boolean determines whether the
pool should be manipulated atomically or not. When
<varname>thr</varname> = <constant>true</constant>, the allocator
- is is thread-safe, while <varname>thr</varname> =
- <constant>false</constant>, and is slightly faster but unsafe for
+ is thread-safe, while <varname>thr</varname> =
+ <constant>false</constant>, is slightly faster but unsafe for
multiple threads.
</para>
Index: doc/xml/manual/containers.xml
===================================================================
--- doc/xml/manual/containers.xml (révision 156082)
+++ doc/xml/manual/containers.xml (copie de travail)
@@ -170,7 +170,7 @@
<code>end()</code>, then the item being inserted should have
a key greater than all the other keys in the container. The
item will be inserted at the end of the container, becoming
- the new entry at <code>end()</code>.
+ the new entry before <code>end()</code>.
</para>
</listitem>
<listitem>
@@ -286,7 +286,7 @@
</para>
<para>
The problem is that <code>vector<bool></code> doesn't
- behave like a normal vector anymore. There have been recent
+ behave like a normal vector anymore. There have been
journal articles which discuss the problems (the ones by Herb
Sutter in the May and July/August 1999 issues of C++ Report cover
it well). Future revisions of the ISO C++ Standard will change
Index: doc/xml/manual/using.xml
===================================================================
--- doc/xml/manual/using.xml (révision 156082)
+++ doc/xml/manual/using.xml (copie de travail)
@@ -655,7 +655,7 @@
(<math.h> in this case), the symbols will be available
in the global namespace and perhaps in
namespace <code>std::</code> (but this is no longer a firm
- requirement.) One the other hand, including the C++-style
+ requirement.) On the other hand, including the C++-style
header (<cmath>) guarantees that the entities will be
found in namespace std and perhaps in the global namespace.
</para>
@@ -808,7 +808,7 @@
std::string;</code>) This approach works well for individual source files, but
should not be used in a global context, like header files.
</para></listitem> <listitem><para>use a <emphasis>fully
-qualified name</emphasis>for each library symbol
+qualified name</emphasis> for each library symbol
(i.e. <code>std::string</code>, <code>std::cout</code>) Always can be
used, and usually enhanced, by strategic use of typedefs. (In the
cases where the qualified verbiage becomes unwieldy.)
Index: doc/xml/manual/locale.xml
===================================================================
--- doc/xml/manual/locale.xml (révision 156082)
+++ doc/xml/manual/locale.xml (copie de travail)
@@ -38,8 +38,8 @@
<para>
Facets actually implement locale functionality. For instance, a facet
-called numpunct is the data objects that can be used to query for the
-thousands separator is in the German locale.
+called numpunct is the data object that can be used to query for the
+thousands separator in the locale.
</para>
<para>
Index: doc/xml/manual/appendix_contributing.xml
===================================================================
--- doc/xml/manual/appendix_contributing.xml (révision 156082)
+++ doc/xml/manual/appendix_contributing.xml (copie de travail)
@@ -172,7 +172,7 @@
<listitem>
<para>
A ChangeLog entry as plain text; see the various
- ChangeLog files for format and content. If using you are
+ ChangeLog files for format and content. If you are
using emacs as your editor, simply position the insertion
point at the beginning of your change and hit CX-4a to bring
up the appropriate ChangeLog entry. See--magic! Similar
Index: ChangeLog
===================================================================
--- ChangeLog (révision 156082)
+++ ChangeLog (copie de travail)
@@ -1,3 +1,11 @@
+2010-01-20 François Dumont <francois.cppdevs@free.fr>
+
+ * manual/allocator.xml: Minor updates and fixes
+ * manual/containers.xml: Likewise
+ * manual/using.xml: Likewise
+ * manual/locale.xml: Likewise
+ * manual/appendix_contributing.xml: Likewise
+
2010-01-20 Janis Johnson <janis187@us.ibm.com>
Paolo Carlini <paolo.carlini@oracle.com>