This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [RFA:] fix non-tls regression with "PATCH: libstdc++/include/profile bug fixes and cleanup"
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>, bkoz at redhat dot com, libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, paolo dot carlini at oracle dot com, rus at google dot com
- Date: Mon, 11 Jan 2010 18:38:31 -0800
- Subject: Re: [RFA:] fix non-tls regression with "PATCH: libstdc++/include/profile bug fixes and cleanup"
- References: <e90dbffc1001100034m5037f79ycb16a54472c88ca8@mail.gmail.com> <201001120227.o0C2RJMs005529@ignucius.se.axis.com>
> Perhaps you did, but I don't see one in 155786 nor elsewhere in
> ext/profile? Or I might have misunderstood.
For a follow-up patch.
> FAIL: ext/profile/all.cc (test for excess errors)
>
> with .log:
> In file included
> from /tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libstdc++-v3/include/profile/impl/profiler_hash_func.h:51:0,
> from /tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libstdc++-v3/include/profile/impl/profiler.h:412,
> from /tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libstdc++-v3/include/profile/base.h:44,
> from /tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libstdc++-v3/include/profile/map.h:38,
> from /tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libstdc++-v3/include/profile/map:38,
> from /tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libstdc++-v3/include/map:69,
> from /tmp/hpautotest-gcc1/gcc/libstdc++-v3/testsuite/ext/profile/all.cc:23: /tmp/hpautotest-gcc1/cris-elf/gccobj/cris-elf/libstdc++-v3/include/profile/impl/profiler_trace.h:62:2:
> error: #error You do not seem to have TLS support, which is required
> by the profile mode. If your program is not multithreaded, recompile
> with -D_GLIBCXX_PROFILE_NO_THREADS compiler exited with status 1
> Index: libstdc++-v3/testsuite/ext/profile/all.cc
> ===================================================================
> --- libstdc++-v3/testsuite/ext/profile/all.cc (revision 155826)
> +++ libstdc++-v3/testsuite/ext/profile/all.cc (working copy)
> @@ -1,4 +1,4 @@
> -// { dg-options "-std=gnu++0x -O0 -D_GLIBCXX_PROFILE" }
> +// { dg-options "-std=gnu++0x -O0 -D_GLIBCXX_PROFILE
Am a bit surprised to see that there is not a dg-require-tls that can
just be plugged in here. I think that's the better approach.
-benjamin