This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 3)

From: Jason Merrill <jason at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Date: Tue, 01 Dec 2009 10:05:22 -0500
Subject: Re: [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 3)
References: <20091130223653.GO22813@hs20-bc2-1.build.redhat.com> <4B149197.4040304@redhat.com> <20091201074526.GP22813@hs20-bc2-1.build.redhat.com>

On 12/01/2009 02:45 AM, Jakub Jelinek wrote:

On Mon, Nov 30, 2009 at 10:46:31PM -0500, Jason Merrill wrote:
On 11/30/2009 05:36 PM, Jakub Jelinek wrote:
	* config/abi/pre/gnu.ver: Don't export certain base dtors that
	weren't previously exported.
Is this necessary?
Yes.

OK.

+ && (SUPPORTS_ONE_ONLY || !DECL_WEAK (fns[0]))


This test seems unnecessary; I don't see the problem with using aliases
on targets with weak symbols but no one-only support.


This is to fix AIX (and is actually unrelated to this patch, it can be dealt
with separately).  In theory it should work well, but David Edelsohn
reported that some symbols were missing from libstdc++.so without it.  I
have no access to AIX and have no idea what AIX linker is doing with the
symbols.

OK.

The patch is OK.

Jason

References:
- Re: [C++ PATCH] Optimize C++ comdat ctors/dtors in classes without virtual bases (PR c++/3187, take 3)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]