Re: [PATCH][libstdc++-v3 parallel mode] Uglification of internal identifiers

[Johannes Singler <singler at ira dot uka dot de>]

Benjamin Kosnik wrote:
>> The attached patch (compressed due to size) uglifies the internals of
>> the libstdc++ parallel mode.
>> Since the uglification changes the line length, the line breaks have
>> to be updated.  I will do this for the (to be proposed) final patch
>> when the uglification itself is approved in principle (its style).
> 
> Great to see this, and great timing. Perhaps the best way to do this is
> on trunk and in stages. 

Stages in what sense?
-Per file?  There are identifiers spanning files.
-Per identifier(s)? Then fix the line breaks each time?

>> 2009-09-10  Johannes Singler  <singler@ira.uka.de>
>>
>>         * include/parallel/*:  Uglify internal identifiers.
>>
>> Shall I specify all files explicitly in the changelog entry?
> 
> Not necessary for casual cleanups I'd say. Although canonical style says
> all files are to be listed.
> 
>> The following lines give an impression on what was changed (add to
>> changelog?):
> 
> Maybe just add the transformations, so as above plus.

Okay. I have attached the whole thing again.

> Change begin* to __begin*.

Where?

> Also, as a side note, for this code:
> 
> +  template<typename _Iterator1, typename _Iterator2, typename
>   _Iterator3,
> +          typename _IteratorCategory>
> +    class _IteratorTriple
>      {
>      private:
> -      typedef iterator_triple<Iterator1, Iterator2, Iterator3,
> -                             IteratorCategory> type;
> +      typedef _IteratorTriple<_Iterator1, _Iterator2, _Iterator3,
> +                             _IteratorCategory> _Self;
> 
> _Self is redundant with just _IteratorTriple. Is this just a style
> thing?

You are right, _Self is redundant.  But I would like to fix that later.

-- Johannes

Attachment: renaming.sh
Description: application/shellscript