This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Updating nth_element for C++0x

From: Christopher Jefferson <caj at cs dot st-andrews dot ac dot uk>
To: Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
Date: Mon, 24 Aug 2009 13:10:37 +0100
Subject: Re: Updating nth_element for C++0x
References: <submission.1MfGRK-0001I9-Ci@mail.cs.st-andrews.ac.uk> <4A926226.70100@oracle.com>

On 24 Aug 2009, at 10:49, Paolo Carlini wrote:

-- Chris

coming to more substantive things, I do not understand why the two __unguarded_partition_pivot call __unguarded_partition in two different ways. In other terms, I would have expected only an additional __comp argument.

Sorry, you are correct, there is a bug in the __comp one, which came from changing some code around and not being consistent. The correct form is:

return __unguarded_partition(__first + 1, __last, *__first, __comp);

Unfortunately, this bug only makes the sort perform poorly, rather than misbehave, which is why I didn't catch it.

Chris

References:
- Updating nth_element for C++0x
  - From: Christopher Jefferson
- Re: Updating nth_element for C++0x
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]