Re: Some extra decorations

[Jonathan Wakely <jwakely dot gcc at gmail dot com>]

2009/5/3 Jan Hubicka:
>> 2009/5/3 Jan Hubicka:
>> > Hi,
>> > re-merging to pretty-ipa shown that there are few extra simple cases
>> > where I missed to add annotations.
>> >
>> > I am now looking if I can get the warnings into low enough noise so it
>> > can be used by default. ?There are some problems with that, in
>> > particular stuff in throw_condtioinally defined in throw-allocator.h
>> > It seems to be plain externally visible function that is defined in
>> > system header. ?Why we do so?
>> > It don't seem to be exported from libstdc++ nor useful in application
>> > (i.e. if I include throw-allocator in multiple source files I get link
>> > error). ?How these headers are supposed to be used?
>>
>> I suspect it's simply broken ?:-)
>>
>> It's used in the libstdc++ testsuite, but in that context it's only
>> ever included in a single translation unit.
>
> If it is only for testing purposes, why it gets installed along with
> other libstdc++ headers?
>>
>> The throw_allocator members should be declared inline.
>
> Seems so :) Or they should go into some CC file linked into libstdc++
> testsuite.

This comment is on line 285:
  // XXX Should be in .cc.

A quicker fix would be to simply make them templates, so the static
data members can be initialised in the header.