This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: More function decorations
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, libstdc++ at gcc dot gnu dot org
- Date: Fri, 17 Apr 2009 15:39:24 +0200
- Subject: Re: More function decorations
- References: <20090417112813.GA17694@kam.mff.cuni.cz> <49E86DC1.2080205@oracle.com>
> Hi,
> > this patch adds Paolo's _GLIBCXX_PURE and _GLIBCXX_CONST macros. I also
> > added _GLIBCXX_NORETURN that is important marker too.
> > For _GLIBCXX_NORETURN I found only one use so far that is in _M_error of
> > debug/formater.h and I added decorations to the stl_tree to finish the
> > file and started in Makefile order with atomic.cc
> > I noticed that atomic already have __attribute__ ((const)) marker and it
> > is missing __const__ around it, so I decided to stop here and discuss
> > procedure. I guess we want to update them to _GLIBCXX_CONST macros for
> > consistency?
> I agree. Patch is Ok with me, just wait a few more hours before
> committing, in particular because I'd like Benjamin to double check the
> atomic bits.
OK, I will update patch to replace __attribute__ ((const)) by
_GLIBCXX_CONST and wait with the patch.
The functions marked contains no volatile stuff in them, so they should
be safe.
Honza
>
> Thanks,
> Paolo.