This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch Ping^2, C++] Move assemble_external call in cp/decl2.c.
- From: Mark Mitchell <mark at codesourcery dot com>
- To: sje at cup dot hp dot com
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Mon, 08 Dec 2008 10:42:27 -0800
- Subject: Re: [Patch Ping^2, C++] Move assemble_external call in cp/decl2.c.
- References: <200810291959.m9TJxrk25612@lucas.cup.hp.com> <4939A68B.4030603@codesourcery.com> <1228759353.6167.16.camel@hpsje.cup.hp.com>
Steve Ellcey wrote:
> It looks like I can simply remove the call to assemble_external from
> mark_used and everything still works fine, which means assemble_external
> is still getting called when needed from somewhere else.
I think we need to figure out where that something else is. Your
empirical evidence (on HP-UX) certainly suggests that this call is
unnecessary, but I'd like to understand what is making sure that we call
assemble_external for a reference to a global function not defined in
the current translation unit.
Once we understand that, the patch is probably OK; certainly, it would
be nice to reduce the presence of this kind of thing in the front ends.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713