This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][libstdc++-v3 parallel mode] Fix name collision PR libstdc++/37470

On Thu, 18 Sep 2008, Johannes Singler wrote:

Uglification will continue...

Tested x86_64-unknown-linux-gnu: No regressions

Please approve for mainline.

2008-09-18 Johannes Singler <singler@ira.uka.de>

       PR libstdc++/37470
       * include/parallel/base.h: Rename log2 to __log2.
	  (__log2) Avoid infinite loop for n <= 0, return 0.
       * include/parallel/losertree.h: Rename log2 to __log2.
       * include/parallel/multiseq_selection.h: Likewise.
       * include/parallel/random_shuffle.h: Likewise.

I would just like to mention PR libstdc++/27340 which says that a leading __ is not such a good way to uglify math function names (solaris libm already uses this scheme).

Well, that's just one more that may have to be changed some day (as this is in a private gcc namespace, I am not sure what the original problem with log2 is, so there might not be any problem with __log2), so please go ahead and ignore this email.

--
Marc Glisse

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]