This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Revision 3: Handle string constant initializers for arrays of char16_t or char32_t
- From: Ian Lance Taylor <iant at google dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Kris Van Hees <kris dot van dot hees at oracle dot com>, Jakub Jelinek <jakub at redhat dot com>, Holger Hopp <holger dot hopp at sap dot com>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Fri, 18 Jul 2008 08:29:09 -0700
- Subject: Re: [PATCH] Revision 3: Handle string constant initializers for arrays of char16_t or char32_t
- References: <20080415223754.GB3887@oracle.com> <480536BB.70308@redhat.com> <20080418021710.GA27409@oracle.com> <87skxjjoe5.fsf@sap.com> <20080418170758.GK2255@devserv.devel.redhat.com> <20080421110001.GB6577@oracle.com> <Pine.LNX.4.64.0804211209280.4213@digraph.polyomino.org.uk> <20080421235942.GF6577@oracle.com> <Pine.LNX.4.64.0806111616040.2430@digraph.polyomino.org.uk> <20080715154432.GG5625@oracle.com> <20080715233016.GH5625@oracle.com> <Pine.LNX.4.64.0807171120250.4051@digraph.polyomino.org.uk>
"Joseph S. Myers" <joseph@codesourcery.com> writes:
> On Tue, 15 Jul 2008, Kris Van Hees wrote:
>
>> gcc/ChangeLog:
>> 2008-07-16 Kris Van Hees <kris.van.hees@oracle.com>
>>
>> * c-common.c (c_stddef_cpp_builtins): Define __CHAR16_TYPE__
>> and __CHAR32_TYPE__.
>> * c-typeck.c (digest_init): Support char16_t and char32_t.
>> (set_nonincremental_init_from_string): Idem.
>
>> gcc/testsuite/ChangeLog:
>> 2008-07-16 Kris Van Hees <kris.van.hees@oracle.com>
>>
>> Tests for char16_t and char32_t support.
>
>> * gcc.dg/utf-array.c: New
>> * gcc.dg/utf-array-short-wchar.c: New
>> * gcc.dg/utf-inc-init.c: New
>> * gcc.dg/utf-type.c: New
>
> These C changes and testcases are OK. I can't approve the C++ changes.
The C++ changes are OK.
Please have a libstdc++ maintainer sign off on the change to
libstdc++-v3/config/abi/pre/gnu.ver. (libstdc++ maintainers: this is
in regard to http://gcc.gnu.org/ml/gcc-patches/2008-07/msg01175.html )
Thanks.
Ian