Re: Arithmetic type emulator helper class for testcases.

["Chris Fairles" <chris dot fairles at gmail dot com>]

On Tue, Jul 15, 2008 at 5:36 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Hi,
>
>> Ok. Here it is in all its glory. I added a few other small
>> changes at the end as well, all just add/remove headers from various tests
>> and such.
>
> Looks almost OK, many thanks again.
>
>> I await the nits! ;)
>
> I have a few ;) Could you please:
> 1- In case you are not using logical operators, prefer
>
> #ifdef blabla
>
> to
>
> #if defined(blabla)
>

Done.

> 2- Double check that the new testcases are -Wall clean (make check CXXFLAGS="-O2 -Wall"

Added __attribute__((unused)).

> 3- Is 20_util/clocks/1.cc really a dg-do link, or can be just a default dg-do run? In case it's really a dg-do link, make sure the dg-do link directive is the *first* one in the file otherwise it interacts badly with the other directives, in particular the dg-require-* (noticed the hard way last time...). Double check any other dg-do * you may have about this annoying issue...

No real reason why it can't be dg-do run. I just did link because I
wasn't making any run-time checks. But, I'm probably going to revisit
the test cases to harden them up once the clock_gettime/-lrt nonsense
has been sorted out and it will be dg-do run then, so might as well do
that now.

> 4- Remember that normally generated files (Makefile.in, configure) are not sent as part of the patch, because may well change between submission and commit (who commits has to regenerate locally anyway).
>

No problemo.

> Thanks!
> Paolo.
>
>

Attached updated patch. (I assume changelog remains the same even w/o
autogenerated file)

Chris

Attachment: chrono_et_al_patch.txt
Description: Text document