This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] Fix Werror breakage (maintainer-mode)
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Sun, 6 Jul 2008 05:08:09 -0500 (CDT)
- Subject: Re: [v3] Fix Werror breakage (maintainer-mode)
- Accept-language: en-US
- References: <20080706094423.GB29777@ins.uni-bonn.de>
> Can somebody enlighten me as to a proper locale_init.cc fix?
Yes, the warning is new and I'd like to understand whether the warning is worrisome or not, or even bogus. That's not clear to me, at the moment. As a LAST resort, the warning could be suppressed via the "usual" trick, something like:
const char* __p = reinterpret_cast<const char*>(c_locale);
return *reinterpret_cast<const locale*>(__p);
which I would consider a tad better than disabling -Werror selectively.
The unwind-pe.h change seems obviously safe to me.
Paolo.