This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][libstdc++-v3 parallel mode] PR 33488 improved


Chris Jefferson wrote:
> On 28/09/2007, Johannes Singler <singler@ira.uka.de> wrote:
>> This should fix PR 33488, and a similar problem for inner_product, also
>> adding corresponding test cases.
>> Improved patch thanks to Sylvain Pion.
> 
> I'm slightly worried about the idea of adding something called
> equal_to, which is almost but not exactly std::equal_to. This seems
> that it might later cause nasty confusion in various ways.
> 
> I had a similar problem when I tried to remove the need for a seperate
> implementation of each function with and without comparitor object,

That a good thing to do, anyway.

> the code produced and reasonably debugged is in libstdc++-v7.Have you
> looked at how this problem was handled there, and considerduglifying
> the non-standard equal_to, to avoid clashes?

Sorry, but I cannot find any information about "libstdc++-v7". Can you
please point me to somewhere?

My proposal would be to prepend "asymmetric_" to the "plus",
"multiplies" and related functors, because they take arguments of
different types. IMHO that's better than just uglifying them.

Johannes


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]