This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] More facets rearrangements


Benjamin Kosnik wrote:

Since collate is actually a facet, shouldn't you be moving it to locale_facets_nonio.h instead?

No, because it's needed when the locale_facets_nonio are certainly *not* needed, e.g., for <iomanip> and <streambuf>. Really, because of locale::operator()(const string&, const string&) must stay together with class locale, this is somthing I really understood only the last days.


I'm not quite sure where you are going though, or maybe I'm not clear on the dependencies, so maybe I'm not getting this. Any chance you could elaborate?

Basically, I'm going nowhere ;) I mean, with this patch, the idea posted before the Meeting is implemented, now <iostream> is about 80 KB smaller. And generally I'm rather happy with the rest, seems consistent: a minimal set of locale "stuff" in the locale_classes headers, then the additional features used in the iostreams and finally the rest. Some additional clean ups are maybe possible, but really, as far as I'm concerned, I'm going to work on something else, for now.


Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]