This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: New AIX libstdc++ testsuite failures

From: Simon Martin <simartin at users dot sourceforge dot net>
To: libstdc++ at gcc dot gnu dot org
Date: Tue, 20 Feb 2007 20:27:36 +0100
Subject: Re: New AIX libstdc++ testsuite failures
References: <200702192241.l1JMfZ835226@makai.watson.ibm.com> <200702200802.46261.simartin@users.sourceforge.net>

Hello.

> I can look into this at the end of the day and send you a patch (I don't
> have access to AIX).
I attach a patch that should fix all the occurences of the reported error on 
AIX. I've tested each modified testcase on i686-pc-linux-gnu with the 
"#if !__GXX_WEAK__" line and the corresponding "#endif" commented out.

Could someone with access to AIX confirm that it is correct?

Thanks in advance,
Simon

2007-02-20  Simon Martin  <simartin@users.sourceforge.net>

	* testsuite/27_io/basic_ios/cons/char/3.cc: Fixed type mismatches in
	explicit instantiations.
	* testsuite/27_io/basic_istream/extractors_other/pod/3983-3.cc: Likewise.
	* testsuite/27_io/basic_istream/extractors_arithmetic/pod/3983-1.cc:
	Likewise.
	* testsuite/27_io/basic_istream/extractors_character/pod/3983-2.cc:
	Likewise.
	* testsuite/27_io/basic_ostream/sentry/pod/1.cc: Likewise.
	* testsuite/21_strings/basic_string/inserters_extractors/pod/10081-in.cc:
	Likewise.
	* testsuite/21_strings/basic_string/inserters_extractors/pod/10081-out.cc:
	Likewise.
	* testsuite/21_strings/basic_string/capacity/1.cc: Likewise.

Index: libstdc++-v3/testsuite/27_io/basic_ios/cons/char/3.cc
===================================================================
--- libstdc++-v3/testsuite/27_io/basic_ios/cons/char/3.cc	(revision 122103)
+++ libstdc++-v3/testsuite/27_io/basic_ios/cons/char/3.cc	(working copy)
@@ -160,11 +160,11 @@ void test02() 
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string<unsigned short>::size_type 
+  const std::basic_string<unsigned short>::size_type 
   std::basic_string<unsigned short>::_Rep::_S_max_size;
 
 template 
-  unsigned short
+  const unsigned short
   std::basic_string<unsigned short>::_Rep::_S_terminal;
 #endif
 
Index: libstdc++-v3/testsuite/27_io/basic_istream/extractors_other/pod/3983-3.cc
===================================================================
--- libstdc++-v3/testsuite/27_io/basic_istream/extractors_other/pod/3983-3.cc	(revision 122103)
+++ libstdc++-v3/testsuite/27_io/basic_istream/extractors_other/pod/3983-3.cc	(working copy)
@@ -61,11 +61,11 @@ void test03()
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string<__gnu_test::pod_ushort>::size_type 
+  const std::basic_string<__gnu_test::pod_ushort>::size_type 
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_max_size;
 
 template 
-  __gnu_test::pod_ushort
+  const __gnu_test::pod_ushort
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_terminal;
 #endif
 
Index: libstdc++-v3/testsuite/27_io/basic_istream/extractors_arithmetic/pod/3983-1.cc
===================================================================
--- libstdc++-v3/testsuite/27_io/basic_istream/extractors_arithmetic/pod/3983-1.cc	(revision 122103)
+++ libstdc++-v3/testsuite/27_io/basic_istream/extractors_arithmetic/pod/3983-1.cc	(working copy)
@@ -62,11 +62,11 @@ void test03()
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string<__gnu_test::pod_ushort>::size_type 
+  const std::basic_string<__gnu_test::pod_ushort>::size_type 
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_max_size;
 
 template 
-  __gnu_test::pod_ushort
+  const __gnu_test::pod_ushort
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_terminal;
 #endif
 
Index: libstdc++-v3/testsuite/27_io/basic_istream/extractors_character/pod/3983-2.cc
===================================================================
--- libstdc++-v3/testsuite/27_io/basic_istream/extractors_character/pod/3983-2.cc	(revision 122103)
+++ libstdc++-v3/testsuite/27_io/basic_istream/extractors_character/pod/3983-2.cc	(working copy)
@@ -66,11 +66,11 @@ void test03()
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string<__gnu_test::pod_ushort>::size_type 
+  const std::basic_string<__gnu_test::pod_ushort>::size_type 
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_max_size;
 
 template 
-  __gnu_test::pod_ushort
+  const __gnu_test::pod_ushort
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_terminal;
 #endif
 
Index: libstdc++-v3/testsuite/27_io/basic_ostream/sentry/pod/1.cc
===================================================================
--- libstdc++-v3/testsuite/27_io/basic_ostream/sentry/pod/1.cc	(revision 122103)
+++ libstdc++-v3/testsuite/27_io/basic_ostream/sentry/pod/1.cc	(working copy)
@@ -114,11 +114,11 @@ void test01()
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string<__gnu_test::pod_ushort>::size_type 
+  const std::basic_string<__gnu_test::pod_ushort>::size_type 
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_max_size;
 
 template 
-  __gnu_test::pod_ushort
+  const __gnu_test::pod_ushort
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_terminal;
 #endif
 
Index: libstdc++-v3/testsuite/21_strings/basic_string/inserters_extractors/pod/10081-in.cc
===================================================================
--- libstdc++-v3/testsuite/21_strings/basic_string/inserters_extractors/pod/10081-in.cc	(revision 122103)
+++ libstdc++-v3/testsuite/21_strings/basic_string/inserters_extractors/pod/10081-in.cc	(working copy)
@@ -76,11 +76,11 @@ void test01()
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string<__gnu_test::pod_ushort>::size_type 
+  const std::basic_string<__gnu_test::pod_ushort>::size_type 
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_max_size;
 
 template 
-  __gnu_test::pod_ushort
+  const __gnu_test::pod_ushort
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_terminal;
 #endif
 
Index: libstdc++-v3/testsuite/21_strings/basic_string/inserters_extractors/pod/10081-out.cc
===================================================================
--- libstdc++-v3/testsuite/21_strings/basic_string/inserters_extractors/pod/10081-out.cc	(revision 122103)
+++ libstdc++-v3/testsuite/21_strings/basic_string/inserters_extractors/pod/10081-out.cc	(working copy)
@@ -76,11 +76,11 @@ void test01()
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string<__gnu_test::pod_ushort>::size_type 
+  const std::basic_string<__gnu_test::pod_ushort>::size_type 
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_max_size;
 
 template 
-  __gnu_test::pod_ushort
+  const __gnu_test::pod_ushort
   std::basic_string<__gnu_test::pod_ushort>::_Rep::_S_terminal;
 #endif
 
Index: libstdc++-v3/testsuite/21_strings/basic_string/capacity/1.cc
===================================================================
--- libstdc++-v3/testsuite/21_strings/basic_string/capacity/1.cc	(revision 122103)
+++ libstdc++-v3/testsuite/21_strings/basic_string/capacity/1.cc	(working copy)
@@ -184,11 +184,11 @@ void test01()
 #if !__GXX_WEAK__
 // Explicitly instantiate for systems with no COMDAT or weak support.
 template 
-  std::basic_string< A<B> >::size_type 
+  const std::basic_string< A<B> >::size_type 
   std::basic_string< A<B> >::_Rep::_S_max_size;
 
 template 
-  A<B>
+  const A<B>
   std::basic_string< A<B> >::_Rep::_S_terminal;
 #endif

Follow-Ups:
- Re: New AIX libstdc++ testsuite failures
  - From: Paolo Carlini
- Re: New AIX libstdc++ testsuite failures
  - From: Benjamin Kosnik

References:
- New AIX libstdc++ testsuite failures
  - From: David Edelsohn
- Re: New AIX libstdc++ testsuite failures
  - From: Simon Martin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]