This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] libstdc++/21172

From: Doug Gregor <dgregor at cs dot indiana dot edu>
To: Paolo Carlini <pcarlini at suse dot de>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
Date: Thu, 15 Feb 2007 09:56:14 -0500
Subject: Re: [Patch] libstdc++/21172
References: <45CF5910.9030304@suse.de>

On Feb 11, 2007, at 12:57 PM, Paolo Carlini wrote:

@@ -427,7 +431,7 @@
       __glibcxx_function_requires(_LessThanComparableConcept<
 	    typename iterator_traits<_RandomAccessIterator>::value_type>)
       __glibcxx_requires_valid_range(__first, __last);
-      //      __glibcxx_requires_heap(__first, __last);
+      __glibcxx_requires_heap(__first, __last);

       while (__last - __first > 1)
 	std::pop_heap(__first, _RandomAccessIterator(__last--));

I can't imagine why that __glibcxx_requires_heap was commented-out. This patch looks good to me.

  Cheers,
  Doug

References:
- [Patch] libstdc++/21172
  - From: Paolo Carlini

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]