Re: TR1 Math Special Functions

[Paolo Carlini <pcarlini at suse dot de>]

Hi,

> I have some fixed.  One or two I'm going to have to XFAIL for now.

Fine, thanks.

> > Besides that, before we can do the first commit, I can see one 
> > blocker issue (really, because affects the bootstrap itself, on some 
> > targets): you are using in many places std::isnan, which, in fact, is 
> > only available if the target supports the C99 math facilities (grep 
> > tr1/cmath about isnan & co, about that). What do you suggest? As a 
> > stopgap solution we could also disable completely the affected code 
> > (but I appreciate your efforts with tgamma, elsewhere... )
>
> Am I allowed to use this:
>      else if (::__gnu_cxx::__capture_isnan(__alpha))
>        return std::numeric_limits<_Tpa>::quiet_NaN();

I don't think you are: if the C99 related macros are undefined, you 
don't find anything useful in namespace __gnu_cxx: have a look to the 
logic in c_std/cmath.

> > Otherwise, I see un-uglified names in struct __numeric_constants, it 
> > would be nice if you could take care of that and well, of course 
> > double check that you are not using unconditionally any other C99 
> > facility (configuring --disable-c99 should help here). But I can take 
> > care of these trivial things, in order to speed-up the process, if 
> > you are willing to look into the above more substantive ones.
>
> I'm now preceding the static function names with two underscores.

Excellent.

Thanks,
Paolo.