Re: [Patch] tr1::hashtable::operator[] (final)

[Paolo Carlini <pcarlini at suse dot de>]

Peter Doerfler wrote:

> It's also a tiny bit faster with my real use case.

Excellent, thanks.

> I think a small comment like
> // reuse hash code and and current bucket for hint-like insertion
> might help to understand what's going on.

I see, I will add some comments in the occasion of the next commit.

> A general question: Will these patches find their way into the 
> 4_0-branch as well? I'm asking since I'd like to use unordered_map 
> which is now much faster in our project. However, our users probably 
> just use distros and those might consider to use 4.0.4 in the 
> future... Well, the more conservative ones might, anyway.

Frankly, I'm not sure. Most of the attention (in all the possible 
meanings) is now devoted to mainline and 4_1-branch. Indeed, can make 
sense to fix proper bugs in the 4_0-branch (like iterator default 
initialization) but performance improvements I don't think qualify.

> > P.S. Peter, for your future contributions, do you have a Copyright 
> > Assignment on file?!?
>
> Unfortunately, no. I didn't think I'd make any code contributions ;-) 
> Right now I'm not affiliated with any company/university. Am I still 
> required to file the assignment?

Well, as far as I know, you are. And I would suggest starting on that 
(boring ;) but necessary task as soon as possible, otherwise your 
possible future patches may remain unapplied :(

Thanks,
Paolo.