This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Testsuite patch to make cxa_atexit test available in gcc subdir
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: sje at cup dot hp dot com
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 10 May 2006 11:31:41 -0500
- Subject: Re: Testsuite patch to make cxa_atexit test available in gcc subdir
- References: <200605092035.NAA00900@hpsje.cup.hp.com>
> I would like to move the dg-require-cxa-atexit definition from the
> libstdc++ subdirectory to the gcc subdirectory so that it can be used by
> tests in the gcc/testsuite/g++ suites (specifically
> g++.old-deja/g++.other/init18.C). The libstdc++ testsuite already gets
> other dg-require-* tests from the gcc subdir so there is no problem with
> the library testsuite continuing to use this check. I also removed the
> definition of dg-require-iconv from the libstdc++ version of
> dg-options.exp while I was there because that function is also defined
> in the gcc subdirectory and libstdc++ can use that one instead of having
> a duplicate version.
Sounds great.
> 2006-05-09 Steve Ellcey <sje@cup.hp.com>
>
>
> * libstdc++/testsuite/lib/libstdc++.exp (check_v3_target_cxa_atexit):
> Remove.
> * libstdc++/testsuite/lib/dg-options.exp (dg-require-iconv): Remove.
> (dg-require-cxa-atexit): Remove.
Please say on the ChangeLog that you are moving to toplevel, not removing.
> 2006-05-09 Steve Ellcey <sje@cup.hp.com>
>
>
> * lib/target-supports-dg.exp (dg-require-cxa-atexit): New.
> * lib/target-supports.dg (check_v3_target_cxa_atexit): New.
I think, for consistency with the other things in this file, this
procedure's name should be changed from
check_v3_target_cxa_atexit
to
check_cxa_atexit_available
I realize this will force mechanical mods to some libstdc++ tests.
These are pre-approved.
-benjamin