This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: TR1 Math
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Ed Smith-Rowland <3dw4rd at verizon dot net>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Wed, 29 Mar 2006 11:54:06 -0600
- Subject: Re: TR1 Math
- References: <44256809.1090102@verizon.net>
Hi Ed! This looks great. It's encouraging to see somebody working on
this difficult piece of TR1.
I have a couple of comments in addition to Paolo's feedback.
1) attribution:
+// Written by Edward Smith-Rowland based on numerous mathematics books.
A bit more detail, please.
2) namespace macro confusion
this:
+_GLIBCXX_BEGIN_NAMESPACE(std)
+
+_GLIBCXX_BEGIN_NAMESPACE(tr1)
should instead be consistent with the other tr1 headers:
+ namespace std
+ {
+_GLIBCXX_BEGIN_NAMESPACE(tr1)
In general, this looks like it is ready to start being checked in, to
me. Do you have your assignment in place?
Also, what is the plan WRT GSL? Is there a plan for cooperation, or is
this just going to be a separate code base? Insights appreciated.
You say:
> I think it would be worthwhile to have a GSL-TR1 deathmatch although
> this might not be appropriate for the testsuite.
Can you elaborate?
-benjamin