This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
V3 PATCH: Compile testsuite support objects with -w
- From: Mark Mitchell <mark at codesourcery dot com>
- To: libstdc++ at gcc dot gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 25 Mar 2005 08:45:46 -0800
- Subject: V3 PATCH: Compile testsuite support objects with -w
- Reply-to: mark at codesourcery dot com
On AIX, compiling testsuite_abi.cc results in warnings, which causes
DeajGNU to treat the compilation as having failed. (DejaGNU doesn't
rely on exit codes because they're not always available.)
Tested on x86_64-unknown-linux-gnu, by observing that "-w" is added to
the compilation line, and that the tests still run.
(A note: Tcl is not a typeful language, but there's no reason not to
take advantage of the facilities it provides. I see a lot of places
where people are confusing strings and lists, and that works most --
but not all -- of the time. The right way to make a list is with the
"list" builtin.)
I intend to apply this within 24 hours, assuming no objections.
However, I'd appreciate an explicit approval so that we can get
people back in business sooner.
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
2005-03-25 Mark Mitchell <mark@codesourcery.com>
* testsuite/lib/libstdc++.exp (v3-build_support): Pass -w when
compiling support objects.
Index: libstdc++.exp
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/lib/libstdc++.exp,v
retrieving revision 1.34
diff -c -5 -p -r1.34 libstdc++.exp
*** libstdc++.exp 23 Mar 2005 21:46:05 -0000 1.34
--- libstdc++.exp 25 Mar 2005 16:39:29 -0000
*************** proc v3-build_support {} {
*** 320,331 ****
# Build the support objects.
set source_files \
[list testsuite_abi.cc testsuite_allocator.cc testsuite_hooks.cc]
foreach f $source_files {
set object_file [file rootname $f].o
if { [v3_target_compile $srcdir/$f $object_file "object" \
! "incdir=$srcdir"]
!= "" } {
error "could not compile $f"
}
append v3-test_objs "$object_file "
}
--- 320,333 ----
# Build the support objects.
set source_files \
[list testsuite_abi.cc testsuite_allocator.cc testsuite_hooks.cc]
foreach f $source_files {
set object_file [file rootname $f].o
+ # Compile with "-w" so that warnings issued by the compiler
+ # do not prevent compilation.
if { [v3_target_compile $srcdir/$f $object_file "object" \
! [list "incdir=$srcdir" "additional_flags=-w"]]
!= "" } {
error "could not compile $f"
}
append v3-test_objs "$object_file "
}