Re: PATCH: Build test .po files during test runs

[Mark Mitchell <mark at codesourcery dot com>]

Benjamin Kosnik wrote:
> > I've not attempted any other simplifications (like changing
> > testsuite_flags not to pass LOCALEDIR, or like changing po/Makefile.am
> > not to build the .mo files), as I didn't want to perturb the other
> > existing scripts yet.  Once they've been assimilated into DejaGNU,
> > then we could consider those cleanups.
>
>
> I think you should kill testsuite_flags passing LOCALEDIR, and do a
> complete transition. 

If you're willing to do a complete transition at this point, we can just 
remove LOCALEDIR from the tests, and replace that "." directly in the 
code.  I'd be happy with that, but that will mean that check_compile 
will not work, unless you have already run the tests with "make check", 
because it is "make check" that will actually create the message 
catalogs.  (That same issue would arise with the patch to check_compile 
that you suggested.)

I think a complete transition would actually involve all of the 
following changes:

1. The patch I posted to make DejaGNU create the .mo files, but without 
the setting of LOCALEDIR, as that will no longer be necessary.

2. Modify the tests that use LOCALEDIR to just hard-code ".".

3. Remove the rules in po/Makefile.am that create the .mo files, as this 
 is now done by DejaGNU.

4. Modify testsuite_flags.in to remove the -DLOCALEDIR setting.

5. Modify acinclude.m4 to remove glibcxx_localedir.

That would still leave the situation described above (that you must run 
"make check" before "check_compile" will work, as it is DejaGNU that 
will actually create the message catalogs).  That will be fixed when 
check_compile is moved into DejaGNU, as per earlier discussions.

I'm happy to prepare a patch that does all of 1-5 above, if you would 
prefer that.  Personally, I'd prefer to check in my current patch as 
posted, and then follow up with a patch to do 2-5, but I'm happy to 
batch it all together, if that's what you'd prefer.  I'm also happy to 
check in my patch, plus yours, plus the change to testsuite_flags.in 
that you suggested, if you still think that's the optimal plan.

What you would like me to do?

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304