Re: PATCH: Run V3 tests on installed compiler

[Phil Edwards <phil at codesourcery dot com>]

On Wed, Mar 23, 2005 at 08:50:14AM -0800, Mark Mitchell wrote:
> 
> Any objections?

Benjamin has already raised the workflow concerns, which I second.
Making changes to this set of files and then rerunning the testsuite on
the reduced set of tests is SOP for maintainers.  If it's still available,
that would be highly desirable.


> (Minor note: libstdc++.exp uses "v3-" as a prefix for some functions;
> it should really be using "libstdc++_" as that is the convention for
> tool configuration files.)

This convention is documented in lib/libstdc++.exp:

# The naming rule is that dg.exp looks for "tool-" and runtest.exp looks
# for "tool_" when finding callbacks.  Utility routines we define for
# our callbacks begin with "v3-".

(And that third line should have "the use of" prepended, really.)  We wanted
a consistent naming scheme which would be guaranteed to never be found
by DejaGNU.


-- 
Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it.
    - Brian W. Kernighan, in a plea for clear, straightforward code