This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3 patch] Add std::tr1::shared_ptr
On Mon, Feb 21, 2005 at 06:25:48PM +0100, Paolo Carlini wrote:
> Paolo Carlini wrote:
>
> >>As far as doing this operation without 'cvs add' well, you could attach
> >>the new file, but then 'patch -p0 < p.whatever' won't work without
> >>additional manual effort. Or, am I just not understanding you?
> >
> >Why would not work? Indeed, I think it's the most appropriate way to
> >proceed
> >in such cases. I'm doing this *always*, I never touch the CVS
> >repository before
> >the actual commit, I never create dirs in advance.
>
> To be clear: since you don't want to alter CVS *before* an approval to
> commit,
> I think the most appropriate way to proceed, in such cases is just that
> recommended
> in the linux kernel, for instance: you copy the entire libstdc++-v3
> tree, create a
> -rN diff and post it to the list.
>
> I don't think it's appropriate suggesting to our contributors to alter
> the CVS
> repository only for the purpose of creating diffs to post... *before*
> the real
> approval of the work!!!
It's also not possible for contributors without write access, since
"cvs add" will fail even for files.
In future I'll diff(1) two whole trees, rather than "cvs diff", if I'm
adding files.
jon
--
Some things have to be believed to be seen.
- Ralph Hodgson