This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Fix PR 17741
Chris Jefferson wrote:
Sorry sorry! I've tried again. Hopefully this patch is correct in all
ways (famous last words...)
;) ;) See below.
I agree. In fact I was torn about if I should bother submitting this,
as I can't see anyone ever actually coming across this bug...
Perfect, the actual patch looks very good to me and if nobody disagree,
I will put it in the branch later today and close the PR.
The ChangeLog entry should be:
2004-10-28 Chris Jefferson <chris@bubblescope.net>
PR libstdc++/17441
* include/bit/stl_algo.h (find(,,,input_iterator_tag)):
Uglify function name.
(find(,,,random_access_interator_tag)): Likewise.
(find_if(,,,input_iterator_tag)): Likewise.
(find_if(,,,random_access_iterator_tag)): Likewise.
(find): Use new uglified specialisation names.
(find_if): Likewise.
* testsuite/25_algorithms/find.cc: New.
To summarize:
1- On top 'PR libstdc++/xxxxx", which triggers Bugzilla scripts.
2- Always capital after the colon.
3- I'm told that 'likewise' is preferred to 'ditto' (but I prefer
the latter because I'm Italian ;)
4- Full stop at the end of each line.
5- No blank lines between related changes (i.e., the testsuite
addition is affectively part of the fix for 17441)
6- Because of 5-, no need to mention again 17741 in the last line.
Finally, in the testcase itself should appear the comment
// libstdc++/17441
Have a look to the 1500 existing examples ;)
Thanks again,
Paolo.