This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: A quick word about the pthreadrope7 fails.


Dhruv Matani wrote:

I don't think that it's a stupid question. Firstly, I do not have access
to a 64-bit machine.

Of course not needed, the header doesn't change. Actually, you don't even need
a computer, since size_t is the type returned by sizeof() and don't you believe that
on a 64-bit machine you are supposed to be able to compute sizes of things bigger
than 4 GB?


Secondly, after you told me stuff like long was
32-bits on 32-bit platforms, and 64-bit on 64-bit ones, I wanted to be
sure what I was doing. After all, I would be held responsible for any
changes that I make to the code. the least I can do is make sure that I
know exactly what I'm doing.


No, that's wrong. We are *both* responsible, since I'm the maintainer approving
your patch. And if you don't trust me after all the past discussions, the game is
over.


I have attached the patch with size_t as the type, and removed _Bitmap_t as you
said.

Is this Ok?


No. There are at least two wrong unsigned int around.

Paolo.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]