Re: Long-standing error in exception handling by pool_allocator (containsuntested patch)

[Paolo Carlini <pcarlini at suse dot de>]

Joachim Kuebart wrote:

> Any comments and ideas are most welcome! I have verified that this patch
> removes the described problem. I have not regression tested the patch because
> I do not have a current version of the library at hand. If requested I will
> catch up on the regression tests as my time permits.
>  
Hi (again ;) Joachim and thanks for the patch!

First blush, it looks correct to me, besided a couple of minor nits:
1- In the library we don't use plain throw but __throw_exception_again 
(this is related
to -fno-exceptions)
2- I think we should catch only std::bad_alloc, not all the possible 
exceptions.

Therefore, my plan would be preparing a simple testcase from your complete
analysis, regression test the slighlty tweaked version, and repost it to 
the list
for final review.

Thanks again,
Paolo.

P.S. Your patch is very small and doesn't require the complete FSF 
paperwork,
luckily!