This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for the allocator.


On Fri, 2004-03-26 at 21:04, Paolo Carlini wrote:
> Dhruv Matani wrote:
> 
> > From the above page I assume that split means the star/splat
> > character(*)?
> >
> > Sorry if I'm being thick, but sometimes, I just don't get certain
> > things!
> 
> Split means, roughly, "divide into two or more parts". Example:
> 
> Right:
> 
> ((a - b)
>  / (c + d))
> 
> Wrong:
> 
> ((a - b) /
>  (c + d))
> 
> In your code you have, f.i.:
> 
>   if (std::less_equal<pointer>()(_M_ptr_value, __bp.second &&
>       std::greater_equal<pointer>()(_M_ptr_value, __bp.first))
> 
> whereas you should prefer:
> 
>   if (std::less_equal<pointer>()(_M_ptr_value, __bp.second
>       && std::greater_equal<pointer>()(_M_ptr_value, __bp.first))
> 
> Agreed?

Ok! Thanks for the detailed explanation!

Sorry for having frustrated you, I guess I'm just like that when it
comes to certain things :-)

> Paolo.
-- 
	-Dhruv Matani.
http://www.geocities.com/dhruvbird/

Proud to be a Vegetarian.
http://www.vegetarianstarterkit.com/
http://www.vegkids.com/vegkids/index.html


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]