This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Handle variable width encodings in basic_filebuf::seekpos
- From: Paolo Carlini <pcarlini at unitus dot it>
- To: Pétur Runólfsson <peturr02 at ru dot is>
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 08 Oct 2003 10:36:19 +0200
- Subject: Re: [PATCH] Handle variable width encodings in basic_filebuf::seekpos
- References: <07D05A69A3D0C14FAEA60C3ACE8E5564028D0E4C@mail.ru.is>
Pétur Runólfsson wrote:
Hi,
This patch adds support for variable width encodings to
basic_filebuf::seekpos. The necessary code was already present in
seekoff, so I moved it into a separate function (_M_seek) and
called that from both seekoff and seekpos.
Great!
While testing the patch, I got a spurious failure in
testsuite/22_locale/locale/cons/12438.cc. It seems the memory limit
was set too low to run the loop even once. I doubled both the
memory limit and the loop count to make the test pass.
Really weird.
On my system the test doesn't consume more than ~1 Mb and I *never* saw
it spuriously failing. Anyway, increasing *both* the numbers is ok with
me and indeed makes the test more robust (but it takes a little longer
to run it ;)
Paolo.