This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Updated patch for std::list: Performance and memory usageimprovements.

>>http://gcc.gnu.org/ml/libstdc++/2003-07/msg00147.html
>>
>>Can you take a look please?
>>
>Yes I'm taking a look.  The warning is absolutely correct and is indeed 
>due to the first stl_tree.h patch.

Yep. Thanks for scoping this.

>>2003-07-08  Gawain Bolton  <gp.bolton@computer.org>
>>
>>	* testsuite/performance/list_create_fill_sort.cc: New.
>>
>Looks good thanks.

Ok then, this is in.

>By the way, any comment on my suggestion to move functionality out of 
>stl_tree.h into an stl_tree.cc source file to be part of libstdc++ 
>library as described in:
>
>    http://gcc.gnu.org/ml/libstdc++/2003-07/msg00107.html

This looks fine to me, with the exception of _S_minimum and _S_maximum,
which are small enough to be inlined if they are defined in-class. 

-benjamin
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]