This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: New C++ ABI baseline files committed to mainline and 3.3


>        * configure.host (freebsd*): Set abi_baseline_pair.
>	[Note: configure.target on 3.3 branch.]
>        * config/abi/i386-freebsd4/baseline_symbols.txt: Update from 3.2
>        (at or near first release) to 3.3.
>        * config/abi/i386-freebsd5/baseline_symbols.txt: New file.
>        * config/abi/alpha-freebsd5/baseline_symbols.txt: New file.
>        * config/abi/sparc-freebsd5/baseline_symbols.txt: New file.

Thanks for doing this. 

Sadly, these baseline files are not sorted. For some reason, 

libstdc++-v3/scripts/extract_symvers:

${readelf} ${lib} | sed '/\.dynsym/,/^$/p;d' | egrep -v ' (LOCAL|UND) ' |\
awk '{ if ($4 == "FUNC" || $4 == "NOTYPE")
         printf "%s:%s\n", $4, $8;
       else if ($4 == "OBJECT")
         printf "%s:%s:%s\n", $4, $3, $8;
     }' | sort | uniq > $tmp 2>&1

Is not producing a sorted output file. Can't figure it out.

Without the sorting, diffs look huge. With properly sorted baseline
files, the diffs are smaller and easier to comprehend.

It would be nice if somebody could fix this before more stuff gets added.

>[Boring, huge new files removed; I diff'd them against others as a
> spot check.  I will include the delta for i386-freebsd4, which looks
> OK being only insertions; I.e. congrats to all that strove to keep a
> stable C++ library ABI from 3.2 to 3.3.X.  Even with the wchar
> configuration difference accounted; there is an interesting
> difference between i386-freebsd4 and i386-freebsd5; appears to affect
> locale::_Impl and may or may not be handled by libc.]

Yay, this is (mostly) good news. Please keep me in the loop about ABI
issues on FreeBSD, even if the moment it's for our own amusement
as the FreeBSD distros haven't really taken advantage of this key
feature.

It does seem to be working well for linux.

best,
benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]