Re: configure.target: overwrites known cpu's to generic

[Andreas Jaeger <aj at suse dot de>]

Matthias Klose <doko@cs.tu-berlin.de> writes:

> Andreas Jaeger writes:
>> Matthias Klose <doko@cs.tu-berlin.de> writes:
>> 
>> > libstdc++'s configure.target does overwrite any "known" cpu to
>> > generic:
>> >
>> > - i486 is overwritten to generic
>> >
>> > - i386 has it's own abi, it's not i486, overwritten to generic anyway
>> >
>> > - s390 is overwritten to generic
>> >
>> > - all other cpu's not handled in the switch are overwritten to generic
>> >   (i.e. mips/mipsel)
>> >
>> > checked on the branch only.
>> 
>> Can you check whether the appended patch fixes this for you, please?
>> 
>> If this does not fix it, please explain a bit more which variable is
>> wrong.  Perhaps I'm looking at the wrong place :-(
>
> hmm, the "*)" catch-all in the switch following your patch overwrites
> try_cpu.

But then it shouldn't work in mainline either.  I see the problem now,
yes your change is necessary.  If it fixes the problem, please commit
it as obvious to both mainline and 3.3 (after changing target_cpu to
host_cpu for mainline).


> I'm testing now the patch attached.

> --- src/libstdc++-v3/configure.target~	2003-06-19 19:55:35.000000000 +0200
> +++ src/libstdc++-v3/configure.target	2003-06-20 09:11:35.000000000 +0200
> @@ -59,9 +59,6 @@
>  # Here we override defaults and catch more general cases due to naming
>  # conventions (e.g., chip_name* to catch all variants).
>  # THIS TABLE IS SORTED.  KEEP IT THAT WAY.
> -if test -d ${glibcpp_srcdir}/config/cpu/${host_cpu}; then
> -  try_cpu=${host_cpu}
> -fi
>  
>  case "${target_cpu}" in
>    alpha*)
> @@ -86,7 +83,11 @@
>      try_cpu=sparc
>      ;;
>    *)
> -    try_cpu=generic
> +    if test -d ${glibcpp_srcdir}/config/cpu/${target_cpu}; then
> +      try_cpu=${target_cpu}
> +    else
> +      try_cpu=generic
> +    fi
>      ;;
>  esac

Thanks,
Andreas
-- 
 Andreas Jaeger, SuSE Linux AG, aj@suse.de, http://www.suse.de/~aj
  GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature