Re: [Patch] Sylvain's fix for libstdc++/10783

[Phil Edwards <phil at jaj dot com>]

On Fri, May 23, 2003 at 11:05:27AM -0700, Nathan Myers wrote:
> > 
> > I propose a ban on all appending to test files. We've got to move over
> > to the single-test-single-file form eventually, might as well do it as
> > cases are added.
> 
> Did I miss that discussion?

Apparently so.  :-)  It was definitely done in public, on this list.

> Why must only one test be performed
> per file?

Because otherwise (what we had up until recently, and still have in many
cases), when a test fails, the tester still has no idea of what actually
broke, only "one of the N tests in this file".  DejaGNU doesn't report
anything more fine-grained, and to honest, I'm not sure anything else
could either.

> It encourages mashing multiple logical tests into a single test,

I don't see how that necessarily follows...

> which seems worse.

...but even if it does, that's why we have public review of patches.


Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams