This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Two other thingies

From: Paolo Carlini <pcarlini at unitus dot it>
To: Pétur Runólfsson <peturr02 at ru dot is>
Cc: libstdc++ at gcc dot gnu dot org
Date: Sun, 04 May 2003 13:10:48 +0200
Subject: Re: [Patch] Two other thingies
References: <07D05A69A3D0C14FAEA60C3ACE8E5564028F5573@nike.hir.is>

Pétur Runólfsson wrote:

This hunk seems dubious:

diff -urN libstdc++-v3-2/include/bits/fstream.tcc libstdc++-v3/include/bits/fstream.tcc --- libstdc++-v3-2/include/bits/fstream.tcc 2003-04-29 21:46:07.000000000 +0200 +++ libstdc++-v3/include/bits/fstream.tcc 2003-05-03 20:31:35.000000000 +0200 @@ -67,8 +67,6 @@ delete [] this->_M_buf; this->_M_buf = NULL; _M_buf_allocated = false; - this->setg(NULL, NULL, NULL); - this->setp(NULL, NULL); } }
I believe filebuf::close() must set pptr() and gptr() to NULL, as sgetc
and sputc should always return EOF when is_open() == false.

I see, probably you are right. Sadly, currently we don't test for this in the testsuite.

To be sure, for the time being I withdraw that hunk.

Paolo.

References:
- RE: [Patch] Two other thingies
  - From: Pétur Runólfsson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]