This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch/RFC] Improve (maybe ;) basic_stringbuf::overflow

From: Paolo Carlini <pcarlini at unitus dot it>
To: Benjamin Kosnik <bkoz at redhat dot com>
Cc: libstdc++ at gcc dot gnu dot org
Date: Fri, 02 May 2003 02:06:55 +0200
Subject: Re: [Patch/RFC] Improve (maybe ;) basic_stringbuf::overflow
References: <3EB185CB.8020301@unitus.it> <20030501190021.49d29816.bkoz@redhat.com>

Benjamin Kosnik wrote:

Looks fine, you might use __tmp like the rest of the local variables,
and move it below the comment.

Agreed! This is of more value now that I have learned that my
improvement for str() was not really 100% safe due to the COW
nature of our basic_string...

Paolo.

References:
- [Patch/RFC] Improve (maybe ;) basic_stringbuf::overflow
  - From: Paolo Carlini
- Re: [Patch/RFC] Improve (maybe ;) basic_stringbuf::overflow
  - From: Benjamin Kosnik

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]