This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gettext markup of library sources


Benjamin Kosnik <bkoz at redhat dot com> writes:

[...]

| The only part used at the moment is the '_(x)' define. That's the part that
| should go in.
| 
| Really, I feel like this patch was preliminary and posted for discussion
| only anyway. 

Agreed.

| One related thing might be to think about standardizing the
| exception.what() messages. With 
| 
| __throw_out_of_range("bitset -- set() argument too large");
| 
| maybe going to something like
| 
| __throw_out_of_range("bitset::set argument too large");
| 
| Too bad there isn't a exception.where() function... anyway. It might be
| nice to have consistent exception strings.

I agree, and I would vote for your proposal:

   __throw_out_of_range("bitset::set argument too large");

Also, I don't think we should spread "_" all over the places:  Just put
it in one place -- the exception constructor that takes the diagnostic
message. 

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]