This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Change named locales in the new codecvt tests


>> I know that the whole approach wrt non-installed locales is
>> in (positive!) flux, but I would like to change the chosen
>> names to something actually installed by the last released
>> version of the library.
>
>Another short follow up: I have just learned that a few widespread
>distributions (e.g., RH8) ship with the en_US.UTF-8 locale
>installed and some other too besides those produced by the
>standard `make localedata/install-locales'. This explains why
>some people are only seeing failures for the /3.cc tests...

Yep. That would be me.

>From your list of "SUPPORTED"
en_AU/ISO-8859-1 \
en_BW/ISO-8859-1 \
en_CA/ISO-8859-1 \
en_DK/ISO-8859-1 \
en_GB/ISO-8859-1 \
en_HK/ISO-8859-1 \
en_IE/ISO-8859-1 \
en_IE@euro/ISO-8859-15 \
en_IN/UTF-8 \
en_NZ/ISO-8859-1 \
en_PH/ISO-8859-1 \
en_SG/ISO-8859-1 \
en_US/ISO-8859-1 \
en_ZA/ISO-8859-1 \
en_ZW/ISO-8859-1 \

>From `locale --all` on RH 8.x:
en_AU
en_AU.iso88591
en_AU.utf8
en_BW
en_BW.iso88591
en_BW.utf8
en_CA
en_CA.iso88591
en_CA.utf8
en_DK
en_DK.iso88591
en_DK.utf8
en_GB
en_GB.iso88591
en_GB.iso885915
en_GB.utf8
en_HK
en_HK.iso88591
en_HK.utf8
en_IE
en_IE@euro
en_IE.iso88591
en_IE.iso885915@euro
en_IE.utf8
en_IE.utf8@euro
en_IN
en_IN.utf8
en_NZ
en_NZ.iso88591
en_NZ.utf8
en_PH
en_PH.iso88591
en_PH.utf8
en_SG
en_SG.iso88591
en_SG.utf8
en_US
en_US.iso88591
en_US.iso885915
en_US.utf8
en_ZA
en_ZA.iso88591
en_ZA.utf8
en_ZW
en_ZW.iso88591
en_ZW.utf8

I don't know where the additional locale aliases come from, or how they
are generated. It is a mystery to me.

>A this point, besides robustifying the testsuite wrt non-installed
>localedata, which is a very good thing IMO, we should either
>use in the testcases locales installed by default by stock glibc (as I
>suggested yesterday), or explain in the docs where the necessary
>localedata can be found/generated via localedef.

Yes. Usually, the person writing the tests picks the locale from `locale
--all`, so this is Petur's ultimate call, I think. (Modulo the issue
above WRT additional locale aliases in RH 8.x).

So, all the bits from your patch are valid.
loc ("en_US.ISO-8859-15");

should be
loc ("en_US.iso885915");

or de_DE.iso885915@euro or is_IS.utf8, whatever.

-benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]