This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Use bit scanning and counting builtins for std::bitset


On Mon, Feb 03, 2003 at 07:18:25PM +0100, Falk Hueffner wrote:
> Benjamin Kosnik <bkoz@redhat.com> writes:
> 
> > >On Sun, Feb 02, 2003 at 03:34:34AM +0100, Falk Hueffner wrote:
> > >> this patch utilizes gcc's builtin functions for bit counting and
> > >> scanning.
> >
> > Formatting issues:
> > 
> > -	while ( __byte_ptr < __end_ptr )
> > 
> > should be
> > -	while (__byte_ptr < __end_ptr)
> 
> Well, that's in the deleted code :) I chose not to fix formatting
> anywhere to keep the patch more readable. But perhaps the whole file
> should be reformatted sometime...

Benjamin needs to stop drinking decaf coffee.  :-)


> > Phil, you might want to try and port this back to 3.2/3.3.
> 
> The gcc builtins are only available in 3.4, I think.

Yep, I just checked that.  (I had to remember what "popcount" was.)


Phil

-- 
I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
                                                 - Edsger Dijkstra, 1930-2002


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]