Re: [v2] reshuffle testsuite/22_locale

[Benjamin Kosnik <bkoz at redhat dot com>]

>	I thought you added the non-NULL test explicitly to avoid crashing
>due to the locale not existing.

This setup was part of existing practice. I just removed the
duplication, and put it all into one function.

// http://gcc.gnu.org/ml/libstdc++/2002-05/msg00038.html

>	As you say, the exception adds a lot of noise.  Either the throw
>needs to be removed, the tests need to be XFAILed on platforms where the
>locale fails, or the infrastructure needs to "expect" that error and not
>consider it a failure.  81 failures really doesn't help me track whether
>the target has a problem.

You can use the attached patch to temporarily remove these fails. The
log you sent was very helpful to me, and in general even though there
are a lot of fails at least I know where the problems lie. Using this
patch will help to see what other fails were introduced.

At some point in the future, it would be nice if ICU could be merged
into the generic locale model, or perhaps an ICU model could be made.
This would probably help things out a lot for non-linux platforms, for
linux users wanting interoperability with IBM java VM's, C++ users of
xerces, etc (and would be nice to have as a configure option on linux as
well.) Anyway.

-benjamin

Index: testsuite/testsuite_hooks.cc
===================================================================
RCS file: /cvs/gcc/gcc/libstdc++-v3/testsuite/testsuite_hooks.cc,v
retrieving revision 1.6
diff -c -p -r1.6 testsuite_hooks.cc
*** testsuite/testsuite_hooks.cc        14 Jan 2003 04:56:55 -0000      1.6
--- testsuite/testsuite_hooks.cc        22 Jan 2003 21:29:52 -0000
*************** namespace __gnu_cxx_test
*** 126,133 ****
        string postLC_ALL= setlocale(LC_ALL, NULL);
        VERIFY( preLC_ALL == postLC_ALL );
        }
-     else
-       throw environment_variable(string("LC_ALL for") + string(name));
    }

    void
--- 126,131 ----
*************** namespace __gnu_cxx_test
*** 150,159 ****
          (*i)();
        setenv(env, oldENV ? oldENV : "", 1);
        }
-     else
-       throw environment_variable(string(env) + string(" to ") + string(name));- #else
-     throw not_found("setenv");
  #endif
    }