This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [3.4] DESTDIR support completed
- From: Andreas Jaeger <aj at suse dot de>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: Christian Cornelssen <ccorn at cs dot tu-berlin dot de>,<gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Thu, 09 Jan 2003 08:55:10 +0100
- Subject: Re: [3.4] DESTDIR support completed
- References: <Pine.LNX.4.33.0301031705420.2540-600000@Dachs.Bau><orvg0zkjtt.fsf@free.redhat.lsd.ic.unicamp.br>
Alexandre Oliva <aoliva@redhat.com> writes:
> Hello, Christian,
>
> Thank you very much for pursuing this goal. destdir4.diff is ok, but
> I'm not entirely comfortable with this change:
>
> On Jan 3, 2003, Christian Cornelssen <ccorn@cs.tu-berlin.de> wrote:
>
>> Index: libstdc++-v3/ChangeLog
>
>> + * include/Makefile.am (install-data-local): [...]
>> + Use ${c_base_builddir} and ${std_builddir}
>> + as destination subdirectories to achieve consistency with
>> + preceding mkinstalldirs commands. No effect because both
>> + variables contain "." only.
>
> I suppose the goal in the Makefile rules is to make it clear that the
> contents of these directories are not meant to be installed in
> subdirectories, even if they were kept in subdirectories in the build
> tree. But then, it may just be a historical left-over from a day in
> which they were kept in separate directories in the build tree.
>
> libstdc++ folks, can you please comment on this?
>
> Regardless, I think we may as well go ahead and install the change,
> even if we have to revert these two lines afterwards. Andreas, I'll
> take your kind offer, if you haven't changed your mind :-) Thank you
> both very much.
Ok, I install this changeset now to CVS mainline.
Thanks for the review, Alexandre, and for the patch, Christian,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj