This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libverbose_terminate, pass 1 of N


On Fri, Dec 20, 2002 at 10:13:04AM -0600, Benjamin Kosnik wrote:
> >    PASS: ext/verbose_terminate.cc (test for excess errors)
> >    terminate called after throwing a `int'
> >    FAIL: ext/verbose_terminate.cc execution test
> >
> >                    === libstdc++-v3 Summary ===
> >
> >    # of expected passes            1
> >    # of unexpected failures        1
> 
> don't know about this

It's definitely a dejagnu thing, if you haven't seen Gaby's later mail.


> >	* src/verb_term.cc:  New file.
> 
> there is already a vterminate.cc, so adding something like verb_term or
> whatever seems confusing.

preload_vterminate.cc?


> >+namespace __gnu_cxx
> >+{
> >+  static struct __Verb_Term_Preload
> >+  {
> >+    __Verb_Term_Preload ()
> >+      { std::set_terminate (__gnu_cxx::__verbose_terminate_handler); }
> >+  } __verb_term_dummy;
> >+}
> 
> this is yet another naming convention. Please think about using
> 
> __[a-z]* or _[A-Z]*

Sure.  I'll produce another patch with new names.


Phil

-- 
I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
                                                 - Edsger Dijkstra, 1930-2002


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]