This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Still improving! (Was: Re: [PATCH] Avoid strtok for thread safety)


>Some time ago, in private mail he alluded to some troubles with memory 
>leaks and static allocation of strings, which led him to resort to C 
>strings (std::strings were in fact used, in the first implementation!). 
>If you browse a bit the repository you will learn, I think, that this 
>happened exactly when Benjamin started to systematically fight memory 
>leaks with Valgrind.

Before std::strings can be used, dealing with a persistent string or
strings for "C" locales needs to be done. I couldn't figure out how to
do this, so I switched. I posted about this on the libstdc++ list, and
there were no other suggestions.

For what's being done here, std::strings are probably overkill, IMHO.
Reasonable people may differ, and do.

If you're worried about exception-safety, you can always add try/catch
blocks around these allocations.

-benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]